<html>
<head><meta charset="utf-8"><title>impl vec in alloc-wg · t-libs/wg-allocators · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/index.html">t-libs/wg-allocators</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html">impl vec in alloc-wg</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="180066044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180066044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Gurwinder Singh <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180066044">(Nov 06 2019 at 19:05)</a>:</h4>
<p><span class="user-mention" data-user-id="216785">@Tim Diekmann</span> I have made a PR to your repo for Vec impl.</p>



<a name="180071887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180071887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180071887">(Nov 06 2019 at 20:08)</a>:</h4>
<p>Nice, thank you! I'll take a look at it soon :)</p>



<a name="180138279"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180138279" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Erich Gubler <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180138279">(Nov 07 2019 at 14:42)</a>:</h4>
<p>Ah man, I was hoping to do this too! D:</p>



<a name="180138293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180138293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Erich Gubler <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180138293">(Nov 07 2019 at 14:42)</a>:</h4>
<p>Feels like I duplicated effort. Bummer.</p>



<a name="180138769"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180138769" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180138769">(Nov 07 2019 at 14:48)</a>:</h4>
<p>I think we should try to merge one PR as soon as possible and work together with a single base :)</p>



<a name="180138871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180138871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180138871">(Nov 07 2019 at 14:49)</a>:</h4>
<p><span class="user-mention" data-user-id="218938">@Gurwinder Singh</span> I have more or less reviewed your PR and made a PR to your code, which should fix the tests. I think the lints can be fixed later.</p>



<a name="180166647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180166647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180166647">(Nov 07 2019 at 19:31)</a>:</h4>
<p>Update:<br>
 all the lints and tests should be fixed by now.</p>



<a name="180621840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180621840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Gurwinder Singh <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180621840">(Nov 13 2019 at 12:53)</a>:</h4>
<p>Vec and String are now implemented in alloc-wg crate and a fork of bumpalo at <a href="https://github.com/95th/bumpalo" target="_blank" title="https://github.com/95th/bumpalo">https://github.com/95th/bumpalo</a> using it</p>



<a name="180621912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180621912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180621912">(Nov 13 2019 at 12:54)</a>:</h4>
<p>Great work, thanks for contributing to the crate :)</p>



<a name="180830570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/180830570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> gnzlbg <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#180830570">(Nov 15 2019 at 13:17)</a>:</h4>
<p>nice!</p>



<a name="181302644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/181302644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#181302644">(Nov 21 2019 at 13:12)</a>:</h4>
<p>You actually forgot to implement <code>Drop</code> <span aria-label="rolling on the floor laughing" class="emoji emoji-1f923" role="img" title="rolling on the floor laughing">:rolling_on_the_floor_laughing:</span></p>



<a name="181310477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/181310477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Gurwinder Singh <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#181310477">(Nov 21 2019 at 14:44)</a>:</h4>
<p>Oops sorry I missed that in may_dangle bit</p>



<a name="181310502"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/181310502" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Gurwinder Singh <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#181310502">(Nov 21 2019 at 14:45)</a>:</h4>
<p>I ll create a PR</p>



<a name="181321611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/181321611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#181321611">(Nov 21 2019 at 16:28)</a>:</h4>
<p>Thanks, I had a fix on a local branch too :)</p>



<a name="181321668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/197181-t-libs/wg-allocators/topic/impl%20vec%20in%20alloc-wg/near/181321668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tim Diekmann <a href="https://rust-lang.github.io/zulip_archive/stream/197181-t-libs/wg-allocators/topic/impl.20vec.20in.20alloc-wg.html#181321668">(Nov 21 2019 at 16:29)</a>:</h4>
<p>Currently copying the crate tests from liballoc and searching for bugs</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>